fix(core): include term description for flat taxonomies in getTaxonomyTerms()#1420
Merged
ascorbic merged 2 commits intoJun 12, 2026
Merged
Conversation
…yTerms() The non-hierarchical branch dropped the already-fetched data column when mapping rows to TaxonomyTerm; only buildTree (hierarchical) parsed it. Closes emdash-cms#1419
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
github-actions
Bot
added
review/needs-review
🦋 Changeset detectedLatest commit: f5f1087 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
![emdashbot[bot]](https://avatars.githubusercontent.com/in/3255304?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This is a clean, well-scoped bug fix. The approach is sound: getTaxonomyTerms() already fetched the data column, and the PR simply adds the same description extraction that the hierarchical branch (buildTree) and getTerm already used. The flat-taxonomy branch was the only place silently dropping it.
I checked:
- The one-line fix matches the existing pattern elsewhere in the module.
- The new unit test covers both flat and hierarchical taxonomies (the PR author verified the flat case fails without the fix).
- Locale filtering is unchanged and correct.
- A changeset is present and well-written.
- No SQL, auth, API route, or admin UI changes, so AGENTS.md conventions around those areas don't apply.
One suggestion: getEntryTerms in the same module also selects data via selectAll("taxonomies") but drops description when mapping rows. It's the exact same bug pattern, so it's worth a quick follow-up if entry-level term rendering also needs descriptions.
github-actions
Bot
added
review/awaiting-author
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
getTaxonomyTerms()already fetches thedatacolumn (selectAll()), but the non-hierarchical branch dropped it when mapping rows toTaxonomyTerm— only hierarchical taxonomies (viabuildTree) parseddescriptionout of it. Descriptions set in the admin UI were silentlyundefinedfor flat taxonomies.This adds the same one-line mapping the hierarchical path uses, plus a unit test covering both kinds of taxonomies (the flat case fails without the fix).
Context: we attach knowledge-graph links (e.g.
wikidata:Q380274) to term descriptions and render them assameAsin JSON-LD; flat taxonomies (tags, treatments) lost them.Closes #1419
Type of change
Checklist
pnpm typecheckpasses (packages/core;@emdash-cms/admin/marketplacebuilds fail on my machine on unrelated tooling, untouched by this PR)pnpm lintpasses (lint:quickclean)pnpm testpasses (targeted:packages/core/tests/unit/taxonomies/— 4 files, 48 tests green; new test red without the fix)pnpm formathas been runemdashpatch)AI-generated code disclosure
Screenshots / test output